This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Explicitly close InputStream in RemoteFileFetcher #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Tested this against the issues I was seeing in #313, and it appears to have done the trick. Can repeatedly run the job without error. |
prax-uber
reviewed
Dec 21, 2018
src/main/java/com/uber/jenkins/phabricator/RemoteFileFetcher.java
Outdated
Show resolved
Hide resolved
|
@prax-uber could I get your eyes on this one again? No rush, just want to make sure it doesn't slip through the cracks... Thanks! |
|
hey @youngmit. Your changes looks good to me but I am not a committer/merger on this repo. |
|
@prax-uber Thanks for the update. Do you know who does have permissions to merge this? I don't even know where to look. |
kageiit
approved these changes
Jan 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #313.