-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tell harbormaster how to link back to jenkins results #76
Conversation
This is necessary for more complex nested arguments instead of just flat kv maps.
@@ -158,10 +159,14 @@ public final boolean perform(final AbstractBuild<?, ?> build, final Launcher lau | |||
|
|||
String commentAction = "none"; | |||
if (runHarbormaster) { | |||
logger.info("harbormaster", "Sending build result to Harbormaster with PHID '" + phid + "', success: " + harbormasterSuccess); | |||
logger.info("harbormaster", "Sending Harbormaster BUILD_URL via PHID: " + phid); | |||
Task.Result sendUriResult = new SendHarbormasterUriTask(logger, diffClient, phid, environment.get("BUILD_URL")).run(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're grabbing the BUILD_URL environment variable above on line 144 -- let's move it out into a final String variable to dedup the logic for fetching it
Looks good, pending some tests |
It would be useful if Differential could provide a link back to Jenkins since engineers will probably want to look at the results of failing builds. This can be accomplished by uploading a uri "artifact" for display. Ideally we would tell Harbormaster the uri as soon as the build is started, but I didn't want to complicated this plugin by adding even more extension points. See https://secure.phabricator.com/T8659 for details.
fb8936f
to
50a3c9a
Compare
Updated with a single env call for |
Looks good! Thanks for the PR. Will merge when tests come back. |
Oracle JDK 8 continues to be broken in Travis. Merging. |
tell harbormaster how to link back to jenkins results
See also https://secure.phabricator.com/T8659