Add the new animations #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,7 +70,7 @@ const defaultProps = { | |||
| orientation: BOTTOM | |||
| }; | |||
|
|
|||
| class Axis extends PureRenderComponent { | |||
| class Axis extends React.Component { | |||
There was a problem hiding this comment.
How come this needs to be changed from PureRenderComponent?
There was a problem hiding this comment.
@chrisirhc You are right. It is still in progress, testing this out.
- Make LineSeries render using React. - Added the animation to the lines. - Added shouldComponentUpdate for the Animation (should be changed to PureRenderComponent later).
…aster); made the source code more readable.
…eries, fixed the event listeners
| const defaultStyle = {i: 0}; | ||
| const style = {i: spring(1)}; | ||
| return ( | ||
| <Motion {...{defaultStyle, style, key: Math.random()}}> |
There was a problem hiding this comment.
What's key: Math.random() for? If it's a required hack, there should be a comment here as well.
There was a problem hiding this comment.
The spring is animated only at the time when motion renders. This means that it requires to be reinitialized somehow to make the next animation.
- Remove the unused function.
| * @private | ||
| */ | ||
| _mouseOverHandler(useValue, d) { | ||
| _mouseOverHandler(useValue, d, event) { |
There was a problem hiding this comment.
How is event passed to this?
There was a problem hiding this comment.
@chrisirhc Event is passed from inside of each of the series. I made the change to make it more transparent.
This was referenced Aug 31, 2016
ayarcohaila
pushed a commit
to ayarcohaila/react-vis
that referenced
this pull request
Jun 30, 2021
Add the new animations
ayarcohaila
added a commit
to ayarcohaila/react-vis
that referenced
this pull request
May 30, 2023
Add the new animations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way how the components are animated:
These changes are made for
XYPlot,RadialChartandTreemap(and all their subcomponents)This issue addresses #55, #91, #114 and #123