Customize RequestRidesButton Text Size #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n to be able to customize font size
|
Thanks for submitting, as mentioned in the issue, we'll be reviewing this soon. It'll likely be next week. Thanks again! |
|
No problem, thanks @tyvsmith |
| } finally { | ||
| textAttributes.recycle(); | ||
| } | ||
| } | ||
|
|
||
| @SuppressLint("ResourceType") | ||
| private void applyTextAttributes(TextView textView, TypedArray textAttributes) { | ||
| private void applyTextAttributes(TextView textView, TypedArray textAttributes, int textSize) { |
There was a problem hiding this comment.
Since we're already pulling in textSize as an attribute, shouldn't we just be able to reference getInt(2) and call setTextSize() without needing new values?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add primary and secondary text size attributes in RideRequestButton to be able to customize font size.
This gives developers certain flexibility to support small, normal and large screens
Please see this related issue:
#34