Jb/initial lib #1
Conversation
gradle/dependencies.gradle
Outdated
|
|
||
| def build = [ | ||
| androidPlugin : "com.android.tools.build:gradle:3.1.0", | ||
| buildToolsVersion : "27.0.3", |
There was a problem hiding this comment.
shouldn't be necessary to specify this anymore
There was a problem hiding this comment.
buildToolsVersion is for the sample app
There was a problem hiding this comment.
Still shouldn't be necessary, AGP sets it on its own
gradle/dependencies.gradle
Outdated
| ] | ||
|
|
||
| def build = [ | ||
| androidPlugin : "com.android.tools.build:gradle:3.1.0", |
There was a problem hiding this comment.
3.1.4 is the latest stable
gradle/dependencies.gradle
Outdated
| */ | ||
|
|
||
| def versions = [ | ||
| kotlin : "1.2.0", |
There was a problem hiding this comment.
had copied from artist. 49ae0be
gradle/dependencies.gradle
Outdated
| gradleAptPlugin : "net.ltgt.gradle:gradle-apt-plugin:0.15", | ||
| gradlePluginsUrl : "https://plugins.gradle.org/m2/", | ||
| minSdkVersion : 16, | ||
| targetSdkVersion : 27 |
There was a problem hiding this comment.
libraries shouldn't specify this (unless it's for the sample)
gradle/dependencies.gradle
Outdated
| def test = [ | ||
| compileTesting : "com.google.testing.compile:compile-testing:0.11", | ||
| junit : 'junit:junit:4.12', | ||
| robolectric : "org.robolectric:android-all:8.1.0-robolectric-4402310", |
There was a problem hiding this comment.
This version looks...weird?
There was a problem hiding this comment.
removed in 49ae0be. don't think i'll need it
stylist/build.gradle
Outdated
| @@ -0,0 +1,16 @@ | |||
| apply plugin: "org.jetbrains.kotlin.jvm" | |||
|
|
|||
| sourceCompatibility = JavaVersion.VERSION_1_7 | |||
There was a problem hiding this comment.
another place that could be java 8
sample/library/build.gradle
Outdated
| check.dependsOn 'checkstyle' | ||
|
|
||
| dependencies { | ||
| api deps.support.appcompat |
There was a problem hiding this comment.
nit: implementation since it's an app
| task checkstyle(type: Checkstyle) { | ||
| source 'src' | ||
| include '**/*.java' | ||
| exclude '**/gen/**' |
There was a problem hiding this comment.
crazy idea - might be worth enabling this on generated code to make sure you're generating valid/well-formed xml?
There was a problem hiding this comment.
between aapt2 and integration tests to be added in #4 we should already be sufficiently covered
There was a problem hiding this comment.
I meant more to be readable
| apply plugin: 'net.ltgt.apt' | ||
| apply plugin: "java-library" | ||
|
|
||
| sourceCompatibility = JavaVersion.VERSION_1_7 |
| ); | ||
|
|
||
| private StyleItemGroup textSizes = new StyleItemGroup( | ||
| new StyleItem("textSizeSmall", "12dp"), |
There was a problem hiding this comment.
I kind think it'd be really good to make the API more pedantic like java/kotlinpoet do. making a sealed class of the types (value, attr, or reference) and make the API more idiomatic to read
DimensionItem("textSizeSmall", 12, Dimen.DP) // Value (can be a nicer form to achieve the next line)
DimensionItem("textSizeSmall", ValueReference("12dp")) // Value
DimensionItem("textSizeSmall", DimensionReference("textSizeTooSmall")) // Reference - to `@dimen/textSizeTooSmall`. Could take an optional namespace arg too
DimensionItem("textSizeSmall", AttrReference("textSizeTooSmall")) // Attr - to `?textSizeTooSmall`. Could take an optional namespace arg tooThere was a problem hiding this comment.
Going to investigate this more in #7
This PR contains the initial creation of this library. It contains the forked, cleaned up, and namespaced copy of resources-poet in addition to the api, core, and top-level modules of the stylist library. A sample providers module and library module are also included, but will be used in a sample app in a followup PR.