Check max string length when using WriteLenXString #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if a long string was passed in, we would overflow the length and write the full string which resulted in a corrupted packet. Instead, return an error if the passed in string is too long for the specified max length (defined by size of the prefix).
Codecov Report
@@ Coverage Diff @@
## dev #728 +/- ##
=========================================
- Coverage 87.63% 87.53% -0.1%
=========================================
Files 40 40
Lines 4075 4075
=========================================
- Hits 3571 3567 -4
- Misses 381 387 +6
+ Partials 123 121 -2
Continue to review full report at Codecov.
|
witriew
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a long string was passed in, we would overflow the length
and write the full string which resulted in a corrupted packet. Instead,
return an error if the passed in string is too long for the specified
max length (defined by size of the prefix).
Plumbing context for the error message would require significant plumbing
and may affect performance, so left it as a generic error.