This repository has been archived by the owner on May 3, 2022. It is now read-only.
Implement a benchmark for the HyperbahnWorker #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raynos
force-pushed
the
hyperbahn-benchmark
branch
from
b521bfa
to
0a8f737
Compare
|
Ready for review. cc: @rf @kriskowal |
Raynos
changed the title
|
I moved the tchannel changes into a seperate PR and landed it. This is just hyperbahn changes. |
|
This looks seaworthy. 🚢 it. |
Raynos
added a commit
that referenced
this pull request
Sep 9, 2015
Implement a benchmark for the HyperbahnWorker
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains both tchannel & hyperbahn changes.
I will break this out into two PRs.
The main change is to refactor TChannel benchmarks to
be more overwritable.
I've added a Hyperbahn benchmark.
You can see the resulting flames here:
r: @rf @jcorbin @kriskowal