Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve workspace support #115

Merged
merged 21 commits into from
Jun 2, 2017
Merged

Improve workspace support #115

merged 21 commits into from
Jun 2, 2017

Conversation

Raynos
Copy link
Contributor

@Raynos Raynos commented Jun 1, 2017 •
edited
Loading

Improve support for "workspace" and multiple GOPATH

  • Fixed PackageHelper to not rely on "gatewayNamespace" and instead rely surely on packageRoot
  • Fixed code to not generate "package name" from thrift file which is incorrect, instead use module system
  • Fixed makefile to support "workspace"
  • Fixed makefile & code coverage tooling to be GOPATH agnostic.

r: @uber/zanzibar-team

Raynos added 21 commits May 31, 2017 14:26
@Raynos
Makefile: add a jenkins-like target for CI
0ffeb50
@Raynos
scripts/generate.sh: make sure we exit if failure
fc87f63
@Raynos
Makefile: cleanup workspace in lint
04ab9b6
@Raynos
codegen/package: add goGatewayNamespace field
fe3044e
@Raynos
codegen/gateway: carry ClientSpec on EndpointSpec
8e6c02e
@Raynos
codegen/module_system: get propere GoPackageName from cspec
c74a03e
@Raynos
codegen/service: remove GoPackage from ModuleSpec
ea1cd0e
@Raynos
codegen/package: remove PackageGenPath() method
b440cf2
@Raynos
Makefile: recursively remove workspace
b3a03bc
@Raynos
Makefile: exclude workspace
27a151b
@Raynos
generate: update golden test files
69e2143
@Raynos
Makefile: excluded workspace
db586df
@Raynos
scripts: add warning for the next guy
f2e7adf
@Raynos
Makefile: do not delete workspace in linter...
1c028cb
@Raynos
scripts/cover: exclude workspace
b527608
@Raynos
tests/codegen: fixup test
3a6d736
@Raynos
Makefile: try exporting all the things
916b2ec
@Raynos
test/lib/test_gateway: exclude workspace in coverage
496559d
@Raynos
Makefile: cleanup makefile
cb1a494
@Raynos
test/lib/gateway: track start & end time
bffda78
@Raynos
codegen/package: get rid of unused gatewayNamespace
9b12ec1
@Raynos Raynos changed the title WIP: Improve workspace support Improve workspace support Jun 2, 2017
stevededalus
stevededalus reviewed Jun 2, 2017
View reviewed changes
scripts/easy_json/easy_json.go
@@ -127,6 +127,7 @@ func main() {
return
}

// Do not paralleliz, not worth it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sp : parallelize

@stevededalus
Copy link
Contributor

LGTM

@Raynos Raynos merged commit b6eaaec into master Jun 2, 2017
@Raynos Raynos deleted the improve-workspace-support branch June 2, 2017 01:54
@CortezFrazierJr CortezFrazierJr mentioned this pull request Nov 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevededalus stevededalus stevededalus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Raynos @stevededalus