Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make yq installation invisible for user #490

Merged
merged 1 commit into from
Oct 12, 2018
Merged

Make yq installation invisible for user #490

merged 1 commit into from
Oct 12, 2018

Conversation

l-w-2017
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.892% when pulling 32cf5c1 on install_yq into 753d1da on master.

@ChuntaoLu
Copy link
Contributor

I thought you were going to vendor yq and use it the same way as thriftrw, what has changed?

@jacobgreenleaf
Copy link
Contributor

I thought you were going to vendor yq and use it the same way as thriftrw, what has changed?

yq is a Python library, the only way to vendor is would be to do something like virtualenv. In general we should revisit this at a later time. The way we have usually solved this is by storing the binaries on some storage like GCS/S3 and downloading them to developer's laptop as needed.

@l-w-2017 l-w-2017 merged commit 68e763b into master Oct 12, 2018
@l-w-2017 l-w-2017 deleted the install_yq branch October 12, 2018 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants