Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for flexible default middleware #558

Merged
merged 7 commits into from
Feb 12, 2019
Merged

Conversation

Ryanfsdf
Copy link
Contributor

@Ryanfsdf Ryanfsdf commented Feb 9, 2019

Introduced support for default middlewares and also the concept of "default dependencies". Default dependencies support glob patterns similar to the recent "flexible directories" feature.

@coveralls
Copy link

coveralls commented Feb 9, 2019

Coverage Status

Coverage increased (+0.2%) to 68.519% when pulling c5b7d2c on flexible-default-middleware into a21d589 on master.

@Ryanfsdf
Copy link
Contributor Author

@ChuntaoLu I know in the last pull request, you mentioned that JSON is no longer supported and we should remove the check for json files in general. However, edge-gateway still uses json files so I've kept the json file checks for compatibility.

@ChuntaoLu
Copy link
Contributor

ChuntaoLu commented Feb 11, 2019

Is this PR supposed to replace #553?

@Ryanfsdf
Copy link
Contributor Author

Ryanfsdf commented Feb 12, 2019

Is this PR supposed to replace #553?

Yes. Although a large portion of this pull request is the same as that pull request, I've had to rework quite a bit of the logic in this one to support glob patterns. I'll close the old pull request.

Hopefully this is the last pull request related to default middlewares (unless there's another big merge conflict, but I don't see any problems with any branches right now)

@ChuntaoLu
Copy link
Contributor

Is this PR supposed to replace #553?

Yes. Although a large portion of this pull request is the same as that pull request, I've had to rework quite a bit of the logic in this one to support glob patterns. I'll close the old pull request.

Hopefully this is the last pull request related to default middlewares (unless there's another big merge conflict, but I don't see any problems with any branches right now)

New PRs makes it hard on review side because the progression/context in the old PR is lost. Ideally we should work on the old PR but I understand in this case because the merge conflict is annoying and hard to manage too.

@Ryanfsdf
Copy link
Contributor Author

Is this PR supposed to replace #553?

Yes. Although a large portion of this pull request is the same as that pull request, I've had to rework quite a bit of the logic in this one to support glob patterns. I'll close the old pull request.
Hopefully this is the last pull request related to default middlewares (unless there's another big merge conflict, but I don't see any problems with any branches right now)

New PRs makes it hard on review side because the progression/context in the old PR is lost. Ideally we should work on the old PR but I understand in this case because the merge conflict is annoying and hard to manage too.

I'll keep note of that for future PRs. Thanks a lot for the review!

@Ryanfsdf Ryanfsdf merged commit 7abaf91 into master Feb 12, 2019
@Ryanfsdf Ryanfsdf deleted the flexible-default-middleware branch February 12, 2019 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants