Debug code + hack to check for tchannel client side bug #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we emit a metric when this happens? Maybe including the client name as well |
smb158
approved these changes
Dec 8, 2020
rpatali
reviewed
Dec 8, 2020
| @@ -412,6 +412,9 @@ func (c *bazClient) EchoBinary( | |||
|
|
|||
| if err == nil && !success { | |||
| switch { | |||
| case result.Success != nil: | |||
| logger.Error("Internal error. Success flag is not set for EchoBinary. Overriding") | |||
There was a problem hiding this comment.
WARN perhaps and not really an error.
rpatali
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue we ran into got us to suspect that the tchannel call was successful, but the "success" flag was not being set by the client call in some cases. Adding a print to catch the event and then treat it as successful.
We will remove this code once the issue is root-caused.