Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register.go Package Import: change endpoint pkg & add middleware pkgs #90

Merged
merged 1 commit into from
May 4, 2017
Merged

Register.go Package Import: change endpoint pkg & add middleware pkgs #90

merged 1 commit into from
May 4, 2017

Conversation

zhenghuiwang
Copy link
Contributor

The package included in register.go for endpoint are incorrect. We actually rely on goImports to add packages for us heuristically, which doesn't work in some environment. This PR fix this by

  • Change the package path to endpoints.
  • Add packages for endpoint middlewares.

r: @uber/zanzibar-team

@coveralls
Copy link

coveralls commented May 4, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.09%) to 69.0% when pulling 7153d92 on fix-reg-imports into b3925e0 on master.

@zhenghuiwang zhenghuiwang merged commit 6524930 into master May 4, 2017
@zhenghuiwang zhenghuiwang deleted the fix-reg-imports branch May 4, 2017 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raynos Raynos Raynos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhenghuiwang @coveralls @Raynos