Feature/scrub interpreter #41
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed the plugins to do the right thing with error conditions.
For better or worse.
Minor other tweaks.
That's about it.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #41 +/- ##
===========================================
- Coverage 69.91% 63.67% -6.25%
===========================================
Files 86 52 -34
Lines 24915 20321 -4594
===========================================
- Hits 17420 12939 -4481
+ Misses 7495 7382 -113
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The counter stuff was messed up because Postgres cares about the type you bind.
There is a fix for the sqlx plugin that specifies the type of
the thing being bound.
There is a fix for blessing tests. I needed to disable all the
noise that the extruder and compiler make.
There is an async block addition too. Now you can create async
blocks and await them:
```rust
fn main() {
let x = async {
let y = 1;
y
};
let z = x.await;
// This will print 1
println!("{}", z);
}
```
`
Ran into this thing with FFi lists not having a type. Sorted it out by giving it the option of a type. Fixed the into value trait impl that's used after the invoke_func call to use the type from the ffi list and not the thing we pass in, which is a result.
Prior to this External Implementation blocks were output with no body. Now this fix is sort of silly because I need to make EIs work. But in addition if there is a block with no statements, we will now also throw an error.
I'm on vacation. I worked on some stuff.
Some Cargo updating and some minor changes to the VM.
The `keys()` method used to return the keys in insertion order, but now returns them in an arbitrary order. This messed up my shit. Now it's fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.