Global channel subscription #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 24, 2013 14:56
… to global channels. (#96)
|
|
||
| The result of the function is the channel id of the newly created | ||
| channel because we might need to use it right away. |
There was a problem hiding this comment.
please use the @param notation to explain each parameter's type, default value and usage
|
LGTM out of context, and it can be merged, but I have two observations
|
…ed to check whether widget should be initialized or not. (#96)
| @@ -302,6 +310,9 @@ define ['cs!mozaic_module', 'cs!pubsub'], (Module) -> | |||
|
|
|||
| $el.addClass("widget-#{name}") | |||
|
|
|||
| # We need to translate global channels into their true uid here | |||
| params.channels = channels_utils.translateGlobalChannels(params.channels) | |||
There was a problem hiding this comment.
@skidding and @topliceanu - I had to move translation here, because widget_starter waits for the channels to be initialized (have data) before initializing the widget. Therefore, the widget will never know that it had GLOBAL channels in the first place! The only one to know will be widget_starter, which seems reasonable - it's the intermediate layer between asking for a widget to be initialized and the widget initialization.
There was a problem hiding this comment.
Nice! gg for making optional effort :)
added 5 commits
June 25, 2013 10:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#96