Add distance-rankings command #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryusuke Chiba <chiba.r221@gmail.com>
takahi-i
reviewed
Jul 11, 2022
| @@ -244,4 +244,52 @@ esqa distance --config sample/compared_ranking.json --index sample --ranking out | |||
| ] | |||
| ``` | |||
|
|
|||
| We get the query cases which change the rankings compared with the rankings before change the settings. | |||
| Or, we can compare between two preserved rankings by distance-rankings command. | |||
|
Deeply sorry for the late response.. 🙇 I will see the changes today. |
takahi-i
reviewed
Jul 11, 2022
| Or, we can compare between two preserved rankings by distance-rankings command. | ||
|
|
||
| ```bash | ||
| esqa distance-rankings --ranking1 output/ranking1.json --ranking2 output/ranking2.json |
There was a problem hiding this comment.
Comparing two saved ranking is useful!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added this command because it's convenient to compare two ranking files.
I thought I could merge this command with the distance command, but it complicates the flags. So I separated.
If you come up with a better name than
ranking-distances, please feel free to modify it.