feat(videoJs): implement videoJs to story video #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KatvonRivia
commented
Mar 11, 2022
| @@ -1,4 +1,12 @@ | |||
| [ | |||
| { | |||
| "id": "debug", | |||
There was a problem hiding this comment.
debug story will be removed once all video features are done, i'm splitting it up in multiple PRs :D
mrMetalWood
approved these changes
Mar 14, 2022
| @@ -0,0 +1,192 @@ | |||
| WEBVTT blah | |||
There was a problem hiding this comment.
Haha, the whole debug story will be deleted later. It's just for testing :D
| import videojs, {VideoJsPlayerOptions} from 'video.js'; | ||
| import {getStoryAssetUrl} from '../../../libs/get-story-asset-urls'; | ||
|
|
||
| import {Language} from '../../../types/language'; |
There was a problem hiding this comment.
I prefer to also indicate with the import that this is a type.
Suggested change
| import {Language} from '../../../types/language'; | |
| import type {Language} from '../../../types/language'; |
There was a problem hiding this comment.
probably doesn't work because it's an enum? 🤔
There was a problem hiding this comment.
Oh ok, than its fine i guess 🤷 :D
KatvonRivia
added a commit
that referenced
this pull request
Mar 16, 2022
* feat(videoJs): implement videoJs to story video * refactor(video): add poster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.