feat(globe): migrate to custom globe implementation #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usefulthink
force-pushed
the
feat/webgl-globe
branch
from
9cf6be4 to
9d1b72d
Compare
- removes cesium dependency - remove old code referencing the cesium globe - replaced cesium specific GlobeView type with CameraView type from @ubilabs/esa-webgl-globe
pwambach
approved these changes
May 12, 2023
| @@ -48,7 +48,6 @@ | |||
| "@datapunt/matomo-tracker-react": "^0.5.1", | |||
| "@reduxjs/toolkit": "^1.9.0", | |||
| "@ubilabs/esa-webgl-globe": "^1.0.0", | |||
| "cesium": "^1.73.0", | |||
| * Manages a single state-variable indicating wether the first tiles of the | ||
| * basemaps have been loaded. | ||
| */ | ||
| function useInitialBasemapTilesLoaded(globe: WebGlGlobe | null) { |
There was a problem hiding this comment.
can this be integrated in the globe itself
pwambach
reviewed
May 24, 2023
| sceneMode, | ||
| imageryProvider: defaultBasemapImageryProvider | ||
| }; | ||
| // fixme: right now @ubilabs/esa-webgl-globe doesn't support the |
There was a problem hiding this comment.
I think these events are handled by react in line 88+89 so no need to implement this in the globe itself. These are just listeners on the containing div to decide which of the two globes is the active one if I remember correctly.
usefulthink
force-pushed
the
feat/webgl-globe
branch
from
404a918 to
2844180
Compare
If we set the selected layer before the details are available, the globe will - for a few frames - render the default globe, which leads to flickering.
usefulthink
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.