feat(globe): wait for layer to load before advancing timestep #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usefulthink
commented
Jun 2, 2023
Comment on lines
+53
to
+59
| const layerLoadingState = useSelector(layerLoadingStateSelector); | ||
| const mainLayerState = mainLayerId | ||
| ? layerLoadingState[mainLayerId] | ||
| : ('idle' as LayerLoadingState); | ||
| const compareLayerState = compareLayerId | ||
| ? layerLoadingState[compareLayerId] | ||
| : ('idle' as LayerLoadingState); |
There was a problem hiding this comment.
maybe we should move this into the parent component and pass it here as a single prop layersLoaded? I think that feels slightly more correct than to pass the layer-ids into this component.
KatvonRivia
reviewed
Jun 5, 2023
| // eslint-disable-next-line no-warning-comments | ||
|
|
||
| useLayerLoadingStateUpdater(globe, props.onLayerLoadingStateChange); | ||
|
|
There was a problem hiding this comment.
Could you pls re-add // eslint-disable-next-line no-warning-comments or open an issue for this? The lint-and-test run is failing. Also deployment would be blocked :)
KatvonRivia
approved these changes
Jun 5, 2023
usefulthink
force-pushed
the
feat/animation-wait-for-render
branch
from
79a7f34 to
eddf8cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.