feat(globe): update to latest version with atmosphere rendering #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: build is failing because I only updated the package.json and not the package-lock.json. But I don't dare to commit that since I had to update to the new major version of vite to be able to run the app. |
@usefulthink Should I commit that one to this branch, then? |
usefulthink
force-pushed
the
feat/globe-atmosphere
branch
2 times, most recently
from
4cf8336 to
cd00c74
Compare
andreashelms
approved these changes
Apr 4, 2024
usefulthink
force-pushed
the
feat/globe-atmosphere
branch
from
cd00c74 to
e5c05e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates to the latest version of the globe which now also supports atmosphere rendering (see here for example: https://storage.googleapis.com/ubilabs-webgl-globe/examples/examples/globe-all-datasets/index.html).