feat(fetch story): display story data in sidepanel #166
Conversation
| import {languageSelector} from '../reducers/language'; | ||
|
|
||
| import {State} from '../reducers/index'; | ||
|
|
| } | ||
| const StoryItem: FunctionComponent<Props> = ({story}) => ( | ||
| <Link to={`/stories/${story.id}`}> | ||
| <Link to={`/stories/${story.id}/0`}> |
There was a problem hiding this comment.
We can remove the /0 now because of the redirect. We don't have to but it looks cleaner :)
| useEffect(() => { | ||
| storyId && dispatch(fetchStory(storyId)); | ||
| }, [storyId, dispatch]); | ||
|
|
There was a problem hiding this comment.
I just saw that we also have to check here if currently loaded story id and storyId from the url are the same. If not we shouldn't render the story. This could happen when someone would switch from one story directly to another. This way the old story is still in the store until the new one if fetched from the server.
| import globeReducer from './globe'; | ||
|
|
||
| const rootReducer = combineReducers({ | ||
| language: languageReducer, | ||
| layers: layersReducer, | ||
| stories: storiesReducer, | ||
| story: storyReducer, |
There was a problem hiding this comment.
We should move all the story related stuff in a subreducer in another PR
src/scripts/reducers/stories.ts
Outdated
| import {State} from './index'; | ||
|
|
||
| export type StoriesState = Story[]; | ||
| export type StoriesState = StoriesItem[]; |
There was a problem hiding this comment.
Could you please rename this to StoryList and StoryListItem and use StoryList everywhere instead of StoriesItem[]
KatvonRivia
changed the title
No description provided.