Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remove-compare): keep main layer when compare globe is removed #197

Merged
merged 6 commits into from
Nov 15, 2019

Conversation

KatvonRivia
Copy link
Member

@KatvonRivia KatvonRivia commented Nov 14, 2019

No description provided.

@KatvonRivia KatvonRivia changed the title fix(remove-compare): keep selected main layer when compare globe is r… fix(remove-compare): keep main layer when compare globe is removed Nov 14, 2019

return (
<div className={styles.removeCompare}>
<Link to="/">
<Link to={`/layers/${mainLayerId}`}>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If no mainLayerId is available this will lead to '/layers/'. This just works fine but I think on the other component we wanted to link the user to '/' in the case no layer is selected.
Maybe you can figure out by yourself how to reach this. 😉

@KatvonRivia KatvonRivia changed the base branch from feat/url-state to develop November 15, 2019 15:49
@KatvonRivia KatvonRivia merged commit 17e3db1 into develop Nov 15, 2019
@KatvonRivia KatvonRivia deleted the fix/remove-compare branch November 15, 2019 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants