feat(mobile-data-mode): add mobile compatibility #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwambach
suggested changes
Aug 19, 2020
| @@ -36,3 +36,6 @@ | |||
| .hideLabel | |||
| span | |||
| display: none | |||
|
|
|||
| button.button.hideLabel | |||
There was a problem hiding this comment.
why the button.button.? Isn't this the same class as the hideLabel above?
There was a problem hiding this comment.
It gets overwritten by
.button, &:not(:first-child) padding-left: emCalc(30px)
in navigation.tsx, so i needed to give it a higher specification.
There was a problem hiding this comment.
Looks to me like the problem should be solved in the navigation component. Not sure if I understand the problem but the "shared" button component shouldn't have to adjust its code because someone who uses the component overwrites its styles.
There was a problem hiding this comment.
Makes sense, thanks! I will change it.
pwambach
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.