feat(story-timeslider): add timeslider to stories #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwambach
suggested changes
Sep 17, 2020
| @@ -165,7 +168,7 @@ const DataViewer: FunctionComponent<Props> = ({ | |||
| action: () => setIsMainActive(false) | |||
| })} | |||
|
|
|||
| {showGlobeNavigation && <GlobeNavigation />} | |||
| {hideNavigation ? showGlobeNavigation : <GlobeNavigation />} | |||
There was a problem hiding this comment.
This is super confusing! showGlobeNavigation is a boolean. Why do you want to render it here? Is it always false? when hideNavigation is true? Then you could just say hideNavigation ? false : <GlobeNavigation /> or even hideNavigation || <GlobeNavigation />.
Not really sure if I understand the logic here :)
| @@ -1,5 +1,6 @@ | |||
| import React, {FunctionComponent, useEffect} from 'react'; | |||
| import {useDispatch} from 'react-redux'; | |||
| // import cx from 'classnames'; | |||
| @@ -72,13 +74,21 @@ const Story: FunctionComponent = () => { | |||
| } else if (slide.type === SlideType.Video && slide.videoId) { | |||
| return <StoryVideo videoId={slide.videoId} />; | |||
| } | |||
| // const timesliderClasses = cx(slide.layerDescription && styles.spacedSlider); | |||
There was a problem hiding this comment.
Please remove and review your own PRs before submitting ;)
pwambach
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #639
closes #577