feat(autoplay-gallery): add autoplay to gallery in showcase mode #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwambach
suggested changes
Sep 24, 2020
|
|
||
| if (currentSlide?.images && currentSlide.type === SlideType.Image) { | ||
| delay = delay * currentSlide.images.length; | ||
| } |
| @@ -15,6 +17,7 @@ export const useStoryNavigation = () => { | |||
| let autoPlayLink = null; | |||
| let nextSlideLink = null; | |||
| let previousSlideLink = null; | |||
| let delay = 3000; | |||
There was a problem hiding this comment.
Would be cool if this value is defined in the config file
| @@ -27,6 +32,15 @@ const StoryMedia: FunctionComponent<Props> = ({ | |||
| const showPrevButton = currentIndex > 0; | |||
| const showNextButton = currentIndex < images.length - 1; | |||
|
|
|||
| useInterval(() => { | |||
There was a problem hiding this comment.
This way the interval function is called every 3 seconds also in non showcase stories. Better put the mode === StoryMode.Showcase check into the delay. If the delay is null the function will not be triggered.
Like:
delay = mode === StoryMode.Showcase ? 3000 : null
|
|
||
| import styles from './story-media.styl'; | ||
|
|
||
| interface Props { | ||
| images: string[]; | ||
| imageCaptions?: string[]; | ||
| storyId: string; | ||
| mode: StoryMode | null; | ||
| } | ||
|
|
||
| const StoryMedia: FunctionComponent<Props> = ({ |
There was a problem hiding this comment.
Another thing but not related to this PR. It's a bit confusing that this component is called StoryMedia and not sth like StoryGallery or StoryImages. At first I thought StoryMedia is a wrapper component for images and videos etc.
There was a problem hiding this comment.
Good point, will rename it in a different PR. 👍
pwambach
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #638