feat(filters): display filter button in data mode #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Badge without number looks fine to me. |
pwambach
suggested changes
Jan 25, 2021
| const selectedLanguage = useSelector(languageSelector); | ||
| const savedLanguage = localStorage.getItem(config.localStorageLanguageKey); | ||
| const [showLanguageBubble, setShowLanguageBubble] = useState<boolean>( | ||
| !savedLanguage | ||
| ); | ||
| const selectedTags = useSelector(selectedTagsSelector); | ||
| const isFilterActive = selectedTags.length > 0; |
There was a problem hiding this comment.
Which filter do you mean?
| @@ -34,6 +40,16 @@ const Navigation: FunctionComponent = () => { | |||
| icon={StoryIcon} | |||
| hideLabelOnMobile | |||
| /> | |||
| {isFilterActive && ( | |||
There was a problem hiding this comment.
I would suggest to rename isFilterActive to isTagFilterActive or you could also just say selectedTags.length && . This makes it easier to understand when the component should be visible.
| @@ -65,6 +81,7 @@ const Navigation: FunctionComponent = () => { | |||
| <Menu /> | |||
| </Overlay> | |||
| )} | |||
| {isFilterActive && showTags && <TagsBubble selectedTags={selectedTags} />} | |||
There was a problem hiding this comment.
The tag selector is not visible when no tag is selected? How can you select a tag then? Also TagsBubble is not a very specific name, I wasn't sure what this component does when reading it.
There was a problem hiding this comment.
The tags are selected in the stories, the user is not supposed to do that in the data view: #823
pwambach
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a badge without the number of selected tags. It seemed a bit too small especially with two digits and was very hard to read.
Here is the design: #823 (comment)
What do you think?
closes #823