Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix router params schema validation #52

Merged
merged 2 commits into from
May 28, 2021
Merged

Conversation

nicck
Copy link
Contributor

@nicck nicck commented May 27, 2021

To use latest node-framework in hotelier these fixes needed:

  • it's not rare then we want to validate parameter format (uuid, date, etc)
  • preprocessed schemas may have optional parameter

Other observations:

  • we still have required for QueryParam, may be we should try to unify DSL for schema definitions
  • a bit strange to not see warning on @QueryParam('nights', { schema: { type: 'integer', min: 1 } }) (should be minimum)
  • example keyword considered invalid now

@nicck nicck marked this pull request as ready for review May 28, 2021 16:21
@nicck nicck merged commit 1d6c123 into main May 28, 2021
@nicck nicck deleted the fix-router-params-schema-validation branch May 28, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants