refactor/general #93
Merged
refactor/general #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
0e6c04c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9265845f.ubiquity-bounty-claims.pages.dev |
| Branch Preview URL: | https://enhancements-styles.ubiquity-bounty-claims.pages.dev |
|
Please help me QA the other pages (when I loaded them they seemed fine) and merge asap. This modifies a lot of files so its best to merge it now that no other hunters are working on it. @rndquu |
Need to fix.
Background and body elements should span to fill sides in dark mode
|
Audit page doesn't support gnosis chain right now (#86) |
rndquu
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small miscellaneous issues that have been bothering me. Started with style enhancements, but realized that there's a lot of cleanup that this codebase needed.
I didn't test the other dApps inside because I'm not familiar with how to use them. Perhaps I could get some help on QA? What is the quick import JSON object I can use to test audits on Gnosis Chain? I believe I am missing valid
APIandRPCproperties.Highlights
globals.d.tsandtsconfig.jsonaddednetworkquery parameter on command linedraw.tsbecause it was broken in an earlier pull request, and due to render performance being poorposition: absoluteorposition: fixedso header and footer behave as expected without overlapping table elements.permit already claimedmessage #91 but will render an error saying that the permit is not claimable (it won't say if its been invalidated or claimed though)