Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

feat: disable bot follow up for pending reviews #708

Merged
merged 9 commits into from
Sep 10, 2023
Merged

feat: disable bot follow up for pending reviews #708

merged 9 commits into from
Sep 10, 2023

Conversation

EtherealGlow
Copy link
Contributor

Resolves #323

@netlify
Copy link

netlify bot commented Sep 2, 2023

Deploy Preview for ubiquibot-staging ready!

Name Link
🔨 Latest commit d31ec44
🔍 Latest deploy log https://app.netlify.com/sites/ubiquibot-staging/deploys/64fc4fb68b4bd000080c11ca
😎 Deploy Preview https://deploy-preview-708--ubiquibot-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@whilefoo whilefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Please post QA

Copy link
Contributor

@0xcodercrane 0xcodercrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for lately jumping here! Left a minor request change.

src/handlers/wildcard/unassign.ts Outdated Show resolved Hide resolved
src/helpers/issue.ts Outdated Show resolved Hide resolved
src/handlers/wildcard/unassign.ts Outdated Show resolved Hide resolved
src/helpers/issue.ts Outdated Show resolved Hide resolved
src/handlers/wildcard/unassign.ts Outdated Show resolved Hide resolved
src/handlers/wildcard/unassign.ts Outdated Show resolved Hide resolved
EtherealGlow and others added 2 commits September 9, 2023 14:10
Co-authored-by: whilefoo <139262667+whilefoo@users.noreply.github.com>
Copy link
Collaborator

@whilefoo whilefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a lot of bugs, next time test your solution and post QA

src/handlers/wildcard/unassign.ts Outdated Show resolved Hide resolved
src/handlers/wildcard/unassign.ts Outdated Show resolved Hide resolved
@EtherealGlow
Copy link
Contributor Author

I'll try to improve that and for the qa, can you help me set up the bot It has worked before for me but it doesn't wanna now

@whilefoo whilefoo merged commit c5a181d into ubiquity:development Sep 10, 2023
9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable the bot follow up on the GitHub issue if there are any pending reviews.
3 participants