Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Configuration.Name and Configuration.Platform into output .csproj #360

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DDev101
Copy link

@DDev101 DDev101 commented Apr 24, 2024

Issue: #359

This is my attempt at fixing this issue.

Configuration Names and Platforms are now generated inside the .csproj description and now show up as proper configurations in visual studio .

Changes include:

  • Modification to ProjectDescription in Csproj.Template to no longer contain PropertyGroup begin/end tags
  • Added ConfigurationsItemBegin ConfigurationsItemEntry ConfigurationsItemEnd properties for generating configuration names
  • Added PlatformsItemBegin PlatformsItemEntry PlatformsItemEnd properties for generating platforms for project configurations
  • Modification to how ProjectDescription is generated when Generate() is called.
    First it writes a PropertyGroupStart, writes ProjectDescription then writes ConfigurationItemBeing/Entry/End items and PlatformsItemBegin/Entry/End items and finally writes a PropertyGroupEnd

@DDev101
Copy link
Author

DDev101 commented Apr 24, 2024

This actually requires updates to tests. I will make a change soon

@DDev101
Copy link
Author

DDev101 commented Apr 24, 2024

On branch "main" it seems that tests are already broken.

I assume there is no relation to this change.

Ready for checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant