Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: quiet curl output in build logs #198

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Conversation

mulderje
Copy link
Contributor

Quiet the output of the akmods curl calls unless there is an error. I noticed these were a bit noisy when looking through some build failure logs. From looking around, these seem to be the most common curl arguments for build scripts (including in curls GH workflows).

Would move output from e.g.

+ curl -L -o /etc/yum.repos.d/_copr_lukenukem-asus-kernel.repo https://copr.fedorainfracloud.org/coprs/lukenukem/asus-kernel/repo/fedora-40/lukenukem-asus-kernel-fedora-40.repo
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   400  100   400    0     0  10780      0 --:--:-- --:--:-- --:--:-- 10526
100   400  100   400    0     0  10745      0 --:--:-- --:--:-- --:--:-- 10526

to (with the removed progress updates)

+ curl -LsSf -o /etc/yum.repos.d/_copr_lukenukem-asus-kernel.repo https://copr.fedorainfracloud.org/coprs/lukenukem/asus-kernel/repo/fedora-40/lukenukem-asus-kernel-fedora-40.repo

unless an error occurred.

If curious, the below details are the details from curl's man page.

-S, --show-error
-s, --silent
-f, --fail

Quiet the output of the akmods curl calls unless there is an error.
@mulderje mulderje requested a review from castrojo as a code owner May 15, 2024 17:09
Copy link
Member

@p5 p5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Have nudged others to take a look too

@castrojo castrojo enabled auto-merge June 5, 2024 19:48
@castrojo castrojo added this pull request to the merge queue Jun 5, 2024
Merged via the queue into ublue-os:main with commit 2da9db2 Jun 5, 2024
30 checks passed
@mulderje
Copy link
Contributor Author

mulderje commented Jun 5, 2024

Thanks!

@mulderje mulderje deleted the quiet-curl branch June 5, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants