Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

Button Colors to Match System #79

Merged
merged 2 commits into from
Sep 16, 2019
Merged

Conversation

cibersheep
Copy link
Contributor

@cibersheep cibersheep commented Jul 10, 2019

Don't merge until I can test on a device

This should close #74

@cibersheep
Copy link
Contributor Author

cibersheep commented Jul 12, 2019

Current vs modified

Flight mode warning:

imatge

Close button:

imatge

Change default SIM:

imatge

Change all SIM associations (to be changed on the next commit):

imatge

@cibersheep cibersheep changed the title WIP: Button Colors to Match System Button Colors to Match System Sep 13, 2019
@cibersheep
Copy link
Contributor Author

Forgot to say it was ok to merge :)

@UniversalSuperBox
Copy link
Member

It looks like the translations file will change with these changes though... It needs to be rebuilt. 😇

@cibersheep
Copy link
Contributor Author

I didn't change any string just the colors... you know me... but I can try to do whateva' is needed ;)

@Flohack74
Copy link
Member

He looked at the screenshots and there are diverging texts, so if you did not change text then maybe you did not compare the same dialogs?

@cibersheep
Copy link
Contributor Author

cibersheep commented Sep 16, 2019

Oops, true. In close buttons both Dialogs are made from the same base but the screenshots are from different messages. I didn't change any text, just the colors:

imatge

@Flohack74 Flohack74 merged commit b67bd89 into ubports:xenial Sep 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

airplane mode mode, both buttons orange
3 participants