-
Notifications
You must be signed in to change notification settings - Fork 2
Fixes grouping albums by album artist rather than just album in the Music app #1
Conversation
Is there an issue filed? Where would I test this? |
Here is the MR for the music app: https://gitlab.com/ubports/apps/music-app/merge_requests/46 If you build this with crossbuilder and compile the music app from that branch you should be able to test the changes (just make sure that you have a multi-artist album on your phone). |
a9cf484
to
442be1d
Compare
Removed my build fixes and updated to include the changes from |
Unfortunately it does not ;) |
Dangit! |
5th time, maybe? |
yay! |
@UniversalSuperBox is this good to go? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tests fine to me, however the commits from #2 have been pulled in uncleanly. Please rebase your branch or reopen this PR to have a clean commit log again.
986e179
to
544fb62
Compare
Ok, should be good now, provided tests pass again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes backwards-incompatible API changes. If we must do this, we'll need to also determine which apps link against this and create a framework version that is not backwards compatible.
@UniversalSuperBox I updated the Album class to not have breaking changes. But the dbus stuff was less straight forward. But since the dbus should just be used by the included qml lib I think everything should be fine. |
No description provided.