Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

Group MMS swipe lock fix #129

Merged
merged 1 commit into from
Sep 8, 2019

Conversation

parksjr
Copy link
Contributor

@parksjr parksjr commented Sep 6, 2019

Simple fix reversing the swipeLocked logic on attachements (always true unless specified false). Tested on Nexus 5 hammerhead. Issue mentioned here: #128

…eturn false unless an attachment item swipeLocked property specifies true.
@krille-chan
Copy link
Collaborator

Thank you for your contribution :)

@krille-chan krille-chan merged commit d97df3e into ubports:xenial Sep 8, 2019
@UniversalSuperBox
Copy link
Member

@parksjr, is there any specific way you would like to be credited in our changelog for our next release? Would you prefer your username, the real name you have set on GitHub...?

For an example, see the changelog at https://ubports.com/blog/ubports-blog-1/post/call-for-testing-ubuntu-touch-ota-10-238

@parksjr
Copy link
Contributor Author

parksjr commented Sep 9, 2019

@UniversalSuperBox github username is fine, thanks!

@ChristianPauly How does one typically celebrate their first successful PR around here? 🍾 😆

@UniversalSuperBox
Copy link
Member

Alright, I can make that happen @parksjr.

Well, if you'd like to celebrate, I can get stickers just about anywhere within the continental US... If you're interested of course. ;)

Other than that, is there anything I can help you find in the project?

@parksjr
Copy link
Contributor Author

parksjr commented Sep 16, 2019

@UniversalSuperBox I am definitely interested in stickers! Nothing I can think of that I need help with right now, but I will certainly reach out if I think of anything. Thanks for the message.

@UniversalSuperBox
Copy link
Member

Alright, you can hit me up on Telegram, @UniversalSuperBox, if that's your jam. Or dalton@ubports.com if that is, instead, your jam.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants