Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config specification v2 #1576

Merged
merged 42 commits into from
Dec 3, 2020
Merged

Config specification v2 #1576

merged 42 commits into from
Dec 3, 2020

Conversation

NeoTheThird
Copy link
Member

@NeoTheThird NeoTheThird commented Nov 25, 2020

This implements a testing ground for v2 of the config file specification. We'll do a near re-write of devices.js to improve stability, maintainability, and extensibility. Additional features enabled by the new specification will be implemented where it makes sense.

This PR will remain a draft while the work is in progress. Implemented changes are listed below. This list will be updated accordingly.

@NeoTheThird NeoTheThird self-assigned this Nov 25, 2020
@codecov-io
Copy link

codecov-io commented Nov 29, 2020

Codecov Report

Merging #1576 (8aa8fe3) into master (71f0ea4) will increase coverage by 18.24%.
The diff coverage is 51.67%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1576       +/-   ##
===========================================
+ Coverage   39.54%   57.79%   +18.24%     
===========================================
  Files          17       24        +7     
  Lines         665      770      +105     
===========================================
+ Hits          263      445      +182     
+ Misses        402      325       -77     
Impacted Files Coverage Δ
src/core/plugins/adb/plugin.js 10.25% <10.25%> (ø)
src/main.js 43.90% <16.66%> (+6.97%) ⬆️
src/core/plugins/systemimage/client.js 17.14% <18.18%> (ø)
src/lib/errors.js 40.00% <20.00%> (-7.37%) ⬇️
src/core/plugins/fastboot/plugin.js 23.61% <23.61%> (ø)
src/core/plugins/heimdall/plugin.js 25.00% <25.00%> (ø)
src/lib/mainEvent.js 32.18% <35.00%> (+4.46%) ⬆️
src/core/deviceTools.js 58.82% <37.50%> (ø)
src/core/plugins/systemimage/plugin.js 38.46% <38.46%> (ø)
src/core/core.js 51.18% <51.18%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71f0ea4...8aa8fe3. Read the comment docs.

@NeoTheThird NeoTheThird marked this pull request as ready for review November 30, 2020 13:22
@NeoTheThird
Copy link
Member Author

Not quite there yet, but we're also making steady progress towards high cohesion and low coupling. There's more we need to do, but this already takes us a long way towards better maintainability and extensibility.
arkit

@NeoTheThird NeoTheThird merged commit e110458 into master Dec 3, 2020
@NeoTheThird NeoTheThird deleted the config-v2 branch December 3, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants