Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Distro.Name private and implemented a constructor and a getter #31

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

EduardGomezEscandell
Copy link
Collaborator

@EduardGomezEscandell EduardGomezEscandell commented Jan 24, 2023

Renaming a distro makes no sense, since the distro's name is the obnly parameter that is used to identify it.

To properly rename a distro one has two options:

  • Export it, unregister it, and re-import it under a different name.
  • Change its name in the registry (applications require elevated privilegesto do so).

Neither of these is in the current scope of GoWSL

@EduardGomezEscandell EduardGomezEscandell self-assigned this Jan 24, 2023
@EduardGomezEscandell EduardGomezEscandell marked this pull request as ready for review January 24, 2023 13:58
Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy change, better for third party consumer as it’s now clear what is read only. Thanks!

@EduardGomezEscandell EduardGomezEscandell merged commit 534bc9d into main Jan 24, 2023
@EduardGomezEscandell EduardGomezEscandell deleted the protect-name branch January 24, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants