Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better testing proposal #222

Merged
merged 4 commits into from
Jul 18, 2022
Merged

Better testing proposal #222

merged 4 commits into from
Jul 18, 2022

Conversation

EduardGomezEscandell
Copy link
Collaborator

@EduardGomezEscandell EduardGomezEscandell commented Jul 14, 2022 •
edited
Loading

Description

The idea is to link in the source files from the project, so their functionality can still be tested.

Status

Ready

Changelog

  • Added DistroLauncher sources to Test solution
  • Added onecore.lib to linker
  • Added definition of g_wslApi in main.cpp (Needed by the compiler even if not used)
  • Removed includes of sourcefiles
  • Added a filter in VS project to keep test- and launcher-sources separate

@EduardGomezEscandell EduardGomezEscandell self-assigned this Jul 14, 2022
@EduardGomezEscandell EduardGomezEscandell mentioned this pull request Jul 14, 2022
Merged
@EduardGomezEscandell EduardGomezEscandell marked this pull request as ready for review July 15, 2022 08:21
This was referenced Jul 15, 2022
Closed
Closed
@EduardGomezEscandell EduardGomezEscandell requested review from CarlosNihelton and removed request for CarlosNihelton July 18, 2022 15:48
@EduardGomezEscandell
Copy link
Collaborator Author

This PR is necessary to make the sudo.h PR testable

CarlosNihelton
CarlosNihelton approved these changes Jul 18, 2022
View reviewed changes
Copy link
Collaborator

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CarlosNihelton CarlosNihelton merged commit 85fbafb into main Jul 18, 2022
@CarlosNihelton CarlosNihelton deleted the better-testing branch July 18, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosNihelton CarlosNihelton CarlosNihelton approved these changes

Assignees

@EduardGomezEscandell EduardGomezEscandell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EduardGomezEscandell @CarlosNihelton