Solved some clang-tidy complaints

[EduardGomezEscandell]

Only made changes in non-microsoft files. Applied most clang-tidy feedback from the last run in main (https://github.com/ubuntu/WSL/runs/7303623016?check_suite_focus=true).

Solved

• Most short-variable-name complaints
• Adding some consts
• NULL -> nullptr
• Removed some unused variable names in lambda arguments. Example: [&](auto&&... s) { return E_UNEXPECTED; }, becomes [&](auto&&...) { return E_UNEXPECTED; },.
• Order of constructor list

Not solved

• Reasonable or standard short variable names (e.g: ok or hr)
• Some variables that I wasn't sure what to rename them to.
• Implicit casts from BOOL (Microsoft's typedef'd int) to bool.

[github-actions]

⚠️ Please check out carefully the isses found by clang-tidy in the new code ⚠️
⚠️ clang-format found formatting issues in the code submitted.:warning:
Make sure to run clang-format and update this pull request.
(1/1)

[CarlosNihelton]

Not solved

• Reasonable or standard short variable names (e.g: ok or hr)

Would you say we should tweak some parameters of the [readability-identifier-length check] ?(https://releases.llvm.org/14.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/readability-identifier-length.html)

• Implicit casts from BOOL (Microsoft's typedef'd int) to bool.

For comparisons (like if(!bSuccess)) we can compare to TRUE or FALSE instead of implicitly converting to bool. For situations where we pass bool as BOOL we can static_cast<BOOL>.

[EduardGomezEscandell]

For comparisons (like if(!bSuccess)) we can compare to TRUE or FALSE instead of implicitly converting to bool. For situations where we pass bool as BOOL we can static_cast.

Agreed and changed.

Would you say we should tweak some parameters of the [readability-identifier-length check] ?

I'd say we should allow hr for variables of type HRESULT as it is the de facto standard. There is only a couple of instances with variables named ok, here I think we can change them to status or success depending on their semantics.

[github-actions]

⚠️ Please check out carefully the isses found by clang-tidy in the new code ⚠️
⚠️ clang-format found formatting issues in the code submitted.:warning:
Make sure to run clang-format and update this pull request.
(1/1)

[github-actions]

⚠️ Please check out carefully the isses found by clang-tidy in the new code ⚠️
⚠️ clang-format found formatting issues in the code submitted.:warning:
Make sure to run clang-format and update this pull request.
(1/1)

[CarlosNihelton]

Thanks for doing this! Really appreciated. Would you mind squashing this one as well?