[CI] Sets a 20 min timeout for clang-tidy #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub history shows that runs over 15 minutes long ended up cancelled. Cancelling is manual. Not sure the cause, but let's limit the runs to 20 minutes for now. This avoids depending on manual cancellations.
CarlosNihelton
changed the title
EduardGomezEscandell
approved these changes
Jul 26, 2022
There was a problem hiding this comment.
LGTM
The longest I found in the last week or so is this one which took 12 minutes. 20 is a good, safe choice but if we felt it necessary we could probably go down to 15 in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub history shows that succesful runs finish under 15 minutes long. Longer runs required manual cancellation.
Not sure the cause, but let's limit the runs to 20 minutes for now to avoid depending on manual cancellations, at least.
GitHub default limit seems too much: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes