Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New app strategy for ARM64 in the context of the new OOBE #254

Merged
merged 3 commits into from
Jul 29, 2022

Conversation

CarlosNihelton
Copy link
Collaborator

It is expected that UDI snap will be replaced by Subiquity only.
Thus GUI will only be supported if Flutter is supported on Windows.
Thus, for ARM64, only TUI will be possible.
Although we could add some checks to the existing NoSplashStrategy,
I'd rather keep them orthogonal as other differences may be detected later on.

The next step is the x64 strategy, which is more complicated, thus I preferred to push on a separate PR.

It is expected that UDI snap will be replaced by Subiquity only.
Thus GUI will only be supported if Flutter is supported on Windows.
Thus, for ARM64, only TUI will be possible.
Although we could add some checks to the existing NoSplashStrategy,
I'd rather keep them orthogonal as other differences may be detected later on.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Please check out carefully the isses found by clang-tidy in the new code ⚠️
⚠️ clang-format found formatting issues in the code submitted.:warning:
Make sure to run clang-format and update this pull request.
(1/1)

DistroLauncher/WinTuiStrategy.h Outdated Show resolved Hide resolved
DistroLauncher/WinTuiStrategy.cpp Outdated Show resolved Hide resolved
@CarlosNihelton CarlosNihelton marked this pull request as ready for review July 29, 2022 09:57
Copy link
Collaborator

@EduardGomezEscandell EduardGomezEscandell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Teeny tiny nitpicks

DistroLauncher/WinTuiStrategy.h Outdated Show resolved Hide resolved
DistroLauncher/WinTuiStrategy.cpp Show resolved Hide resolved
DistroLauncher/WinTuiStrategy.cpp Show resolved Hide resolved
@CarlosNihelton CarlosNihelton merged commit b3cfed1 into main Jul 29, 2022
@CarlosNihelton CarlosNihelton deleted the winoobe-arm64-deeng-346 branch July 29, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants