Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: switch to team PPA for Azure VPN #1029

Merged
merged 1 commit into from
Jun 17, 2024
Merged

ci: switch to team PPA for Azure VPN #1029

merged 1 commit into from
Jun 17, 2024

Conversation

GabrielNagy
Copy link
Contributor

I've repackaged ppp and sstp-client in the team PPA for both Jammy and Noble, so that we are not affected by when the ubuntu-latest runner transitions to Noble on GitHub Actions.

Here's a passing run with ubuntu-latest (aka 22.04): https://github.com/GabrielNagy/adsys/actions/runs/9502739724
And with ubuntu-24.04: https://github.com/GabrielNagy/adsys/actions/runs/9506065559

Fixes UDENG-3048

I've repackaged ppp and sstp-client in the team PPA for both Jammy and
Noble, so that we are not affected by when the ubuntu-latest runner
transitions to Noble on GitHub Actions.
@GabrielNagy GabrielNagy requested a review from a team as a code owner June 13, 2024 21:19
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.80%. Comparing base (6610fb3) to head (9814961).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1029   +/-   ##
=======================================
  Coverage   93.80%   93.80%           
=======================================
  Files          79       79           
  Lines        6881     6881           
=======================================
  Hits         6455     6455           
  Misses        416      416           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

@GabrielNagy GabrielNagy merged commit 48227e2 into main Jun 17, 2024
4 checks passed
@GabrielNagy GabrielNagy deleted the test-new-vpn-ppa branch June 17, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants