-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DCONF policy manager removing userdb on empty policy #1070
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1070 +/- ##
==========================================
+ Coverage 93.80% 93.84% +0.03%
==========================================
Files 79 79
Lines 6881 6873 -8
==========================================
- Hits 6455 6450 -5
+ Misses 416 413 -3
Partials 10 10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feeling sorry to see this revert from Gabriel's code, but yeah, necessary, I just have a suggestion on adding some comments in the tests, to ensure this time we don’t drop it without a second thought…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adjusted the comments in the proposal to be more exact :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let’s restore dconf \o/
The reverted commit was before we added support for multiple backends, so we need to update the golden files for these tests.
8bd2829
to
8a473d6
Compare
We decided to go for this approach to support the
purge
command. Since it's not yet fully functional and this change is breaking user sessions that do not have at least one DCONF-related policy applied, we should revert this change for now and consider a better way of removing the leftover files in the future.Closes #1002.
UDENG-3732.