Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DCONF policy manager removing userdb on empty policy #1070

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

denisonbarbosa
Copy link
Member

We decided to go for this approach to support the purge command. Since it's not yet fully functional and this change is breaking user sessions that do not have at least one DCONF-related policy applied, we should revert this change for now and consider a better way of removing the leftover files in the future.

Closes #1002.

UDENG-3732.

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.84%. Comparing base (2f9beeb) to head (8a473d6).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1070      +/-   ##
==========================================
+ Coverage   93.80%   93.84%   +0.03%     
==========================================
  Files          79       79              
  Lines        6881     6873       -8     
==========================================
- Hits         6455     6450       -5     
+ Misses        416      413       -3     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feeling sorry to see this revert from Gabriel's code, but yeah, necessary, I just have a suggestion on adding some comments in the tests, to ensure this time we don’t drop it without a second thought…

internal/policies/dconf/dconf_test.go Show resolved Hide resolved
Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I adjusted the comments in the proposal to be more exact :)

internal/policies/dconf/dconf_test.go Outdated Show resolved Hide resolved
internal/policies/dconf/dconf_test.go Outdated Show resolved Hide resolved
Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let’s restore dconf \o/

denisonbarbosa and others added 2 commits August 28, 2024 08:45
This reverts commit bed0d79, reversing
changes made to 0163cbb.

Co-authored-by: Didier Roche-Tolomelli <didrocks@ubuntu.com>
The reverted commit was before we added support for multiple backends,
so we need to update the golden files for these tests.
@denisonbarbosa denisonbarbosa merged commit db591d9 into main Aug 28, 2024
4 checks passed
@denisonbarbosa denisonbarbosa deleted the fix-dconf-empty-profile branch August 28, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue: Get error: unable to open named profile (user): using the null configuration.
3 participants