-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps(go-tools): bump github.com/golangci/golangci-lint from 1.59.1 to 1.60.3 in /tools #1077
deps(go-tools): bump github.com/golangci/golangci-lint from 1.59.1 to 1.60.3 in /tools #1077
Conversation
Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.59.1 to 1.60.3. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.59.1...v1.60.3) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1077 +/- ##
==========================================
- Coverage 93.80% 93.78% -0.03%
==========================================
Files 79 79
Lines 6881 6900 +19
==========================================
+ Hits 6455 6471 +16
- Misses 416 419 +3
Partials 10 10 ☔ View full report in Codecov by Sentry. |
97f3009
to
86acdb8
Compare
86acdb8
to
7b102de
Compare
Passing now a pointer to the error as the API changed to allow using defer. Co-authored-by: Jean-Baptiste Lallement <jean-baptiste@ubuntu.com>
448c038
to
28b6731
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small question, but won't block on it. Thanks for addressing all of this!
Annotate false positive linting due to string const being localized Fix the logContextKey not being an anonymous struct Co-authored-by: Jean-Baptiste Lallement <jean-baptiste@ubuntu.com>
28b6731
to
2b276ee
Compare
@denisonbarbosa mind double checking I didn’t let one of them? Code Sanity passes |
Everything looks great. Well done! |
Bumps github.com/golangci/golangci-lint from 1.59.1 to 1.60.3.
Release notes
Sourced from github.com/golangci/golangci-lint's releases.
... (truncated)
Changelog
Sourced from github.com/golangci/golangci-lint's changelog.
... (truncated)
Commits
c2e095c
build(deps): bump github.com/securego/gosec/v2 from 81cda2f91fbe to ab3f6c1c8...f0c1904
feat: check that Go version use to build is greater or equals to the Go versi...2f53f2c
docs: update documentation (#4931)1bdd38b
docs: update documentation assets (#4930)561049d
docs: update GitHub Action assets (#4929)f338f3e
build(deps): bump github.com/securego/gosec/v2 from 5f0084eb01a9 to 81cda2f91...741df1f
dev: fix GO_VERSION in post release workflow (#4926)87dd8fe
exportloopref: deprecation (#4916)af298e1
chore: update gofmt (#4923)132d81c
build(deps): bump github.com/tomarrell/wrapcheck/v2 from 2.8.3 to 2.9.0 (#4921)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)UDENG-4223