Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(go-tools): bump github.com/golangci/golangci-lint from 1.59.1 to 1.60.3 in /tools #1077

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 26, 2024

Bumps github.com/golangci/golangci-lint from 1.59.1 to 1.60.3.

Release notes

Sourced from github.com/golangci/golangci-lint's releases.

v1.60.3

golangci-lint is a free and open-source project built by volunteers.

If you value it, consider supporting us, the maintainers and linter authors.

We appreciate it! ❤️

For key updates, see the changelog.

Changelog

  • c2e095c022a97360f7fff5d49fbc11f273be929a build(deps): bump github.com/securego/gosec/v2 from 81cda2f91fbe to ab3f6c1c83a0 (#4943)
  • f0c190436343e51e6b4dc98a368cf7bae0e5f33a feat: check that Go version use to build is greater or equals to the Go version of the project (#4938)

v1.60.2

golangci-lint is a free and open-source project built by volunteers.

If you value it, consider supporting us, the maintainers and linter authors.

We appreciate it! ❤️

For key updates, see the changelog.

Changelog

  • f338f3ef33f0f7b641100aa1fd759549cc959a8b build(deps): bump github.com/securego/gosec/v2 from 5f0084eb01a9 to 81cda2f91fbe (#4927)
  • 132d81cb5a37a48b190b3fbb58eeb7fcc754f71a build(deps): bump github.com/tomarrell/wrapcheck/v2 from 2.8.3 to 2.9.0 (#4921)
  • 15529a9d74d8b6904d7da121c6f8c96e502c070c build(deps): bump honnef.co/go/tools from 0.5.0 to 0.5.1 (#4911)
  • e24ef74f8f63de3d1a31834c2754f31b32e571c3 build(deps): bump mvdan.cc/gofumpt from 0.6.0 to 0.7.0 (#4922)
  • 87dd8fe7552a8c8374ebde29db3bda8b28055962 exportloopref: deprecation (#4916)
  • ca0b09e5e3891abef239b7c14459c6fba90e796e gosec: add G602 analyzer (#4906)
  • adbdfdb288e939a175182b7a12b7555215ce98b2 staticcheck: propagate Go version (#4907)

v1.60.1

golangci-lint is a free and open-source project built by volunteers.

If you value it, consider supporting us, the maintainers and linter authors.

We appreciate it! ❤️

For key updates, see the changelog.

Changelog

  • 1147824c go1.23 support (#4836)
  • 9eeb891c build(deps): bump golang.org/x/tools from 0.23.0 to 0.24.0 (#4898)
  • 73bbf822 build(deps): bump github.com/polyfloyd/go-errorlint from 1.5.2 to 1.6.0 (#4899)
  • a9ea7d32 unused: remove exported-is-used option
  • 90664f6c build(deps): bump golangci/golangci-lint-action from 6.0.1 to 6.1.0 (#4893)
  • 78a738f7 unused: remove exported-is-used option (#4890)
  • 5536bb5c build(deps): bump github.com/mgechev/revive from 1.3.7 to 1.3.9 (#4886)
  • f903621d build(deps): bump github.com/gofrs/flock from 0.12.0 to 0.12.1 (#4889)

... (truncated)

Changelog

Sourced from github.com/golangci/golangci-lint's changelog.

v1.60.3

  1. Updated linters
    • gosec: from 81cda2f91fbe to ab3f6c1c83a0 (fix G115 false positives)
  2. Misc.
    • Check that the Go version use to build is greater or equals to the Go version of the project

v1.60.2

  1. Updated linters
  • gofmt: update to HEAD (go1.22)
  • gofumpt: from 0.6.0 to 0.7.0
  • gosec: fix G602 analyzer
  • gosec: from 5f0084eb01a9 to 81cda2f91fbe (adds G115, G405, G406, G506, G507)
  • staticcheck: from 0.5.0 to 0.5.1
  • staticcheck: propagate Go version
  • wrapcheck: from 2.8.3 to 2.9.0
  • ⚠️ exportloopref: deprecation

v1.60.1

  1. Updated linters
    • errorlint: from 1.5.2 to 1.6.0
    • exhaustruct: from 3.2.0 to 3.3.0 (recognize custom error values in return)
    • fatcontext: from 0.2.2 to 0.4.0 (fix false positives for context stored in structs)
    • gocognit: from 1.1.2 to 1.1.3
    • gomodguard: from 1.3.2 to 1.3.3
    • govet (printf): report non-constant format, no args
    • lll: advertise max line length instead of just reporting failure
    • revive: from 1.3.7 to 1.3.9 (new rule: comments-density)
    • sloglint: from 0.7.1 to 0.7.2
    • spancheck: from 0.6.1 to 0.6.2
    • staticcheck: from 0.4.7 to 0.5.0
    • tenv: from 1.7.1 to 1.10.0 (remove reports on fuzzing)
    • testifylint: from 1.3.1 to 1.4.3 (new options: formatter, suite-broken-parallel, suite-subtest-run)
    • tparallel: from 0.3.1 to 0.3.2
    • usestdlibvars: from 1.26.0 to 1.27.0 (fix false-positive with number used inside a mathematical operations)
    • wsl: from 4.2.1 to 4.4.1
    • ⚠️ unused: remove exported-is-used option
  2. Fixes
    • SARIF: sanitize level property
    • ⚠️ typecheck issues should never be ignored
  3. Documentation
    • Add link on linter without configuration
    • Remove 'trusted by' page
    • wsl update documentation of the configuration
  4. misc.
    • 🎉 go1.23 support

v1.60.0

... (truncated)

Commits
  • c2e095c build(deps): bump github.com/securego/gosec/v2 from 81cda2f91fbe to ab3f6c1c8...
  • f0c1904 feat: check that Go version use to build is greater or equals to the Go versi...
  • 2f53f2c docs: update documentation (#4931)
  • 1bdd38b docs: update documentation assets (#4930)
  • 561049d docs: update GitHub Action assets (#4929)
  • f338f3e build(deps): bump github.com/securego/gosec/v2 from 5f0084eb01a9 to 81cda2f91...
  • 741df1f dev: fix GO_VERSION in post release workflow (#4926)
  • 87dd8fe exportloopref: deprecation (#4916)
  • af298e1 chore: update gofmt (#4923)
  • 132d81c build(deps): bump github.com/tomarrell/wrapcheck/v2 from 2.8.3 to 2.9.0 (#4921)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

UDENG-4223

Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.59.1 to 1.60.3.
- [Release notes](https://github.com/golangci/golangci-lint/releases)
- [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
- [Commits](golangci/golangci-lint@v1.59.1...v1.60.3)

---
updated-dependencies:
- dependency-name: github.com/golangci/golangci-lint
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner August 26, 2024 14:35
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Aug 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 6 lines in your changes missing coverage. Please review.

Project coverage is 93.78%. Comparing base (258c929) to head (073d925).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
internal/adsysservice/adsysservice.go 60.00% 2 Missing ⚠️
internal/authorizer/servercreds.go 50.00% 2 Missing ⚠️
internal/adsysservice/service.go 75.00% 1 Missing ⚠️
internal/authorizer/authorizer.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1077      +/-   ##
==========================================
- Coverage   93.80%   93.78%   -0.03%     
==========================================
  Files          79       79              
  Lines        6881     6900      +19     
==========================================
+ Hits         6455     6471      +16     
- Misses        416      419       +3     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jibel jibel force-pushed the dependabot/go_modules/tools/github.com/golangci/golangci-lint-1.60.3 branch from 97f3009 to 86acdb8 Compare August 26, 2024 15:47
@jibel jibel force-pushed the dependabot/go_modules/tools/github.com/golangci/golangci-lint-1.60.3 branch from 86acdb8 to 7b102de Compare August 26, 2024 16:41
Passing now a pointer to the error as the API changed to allow using
defer.

Co-authored-by: Jean-Baptiste Lallement <jean-baptiste@ubuntu.com>
@didrocks didrocks force-pushed the dependabot/go_modules/tools/github.com/golangci/golangci-lint-1.60.3 branch 6 times, most recently from 448c038 to 28b6731 Compare August 29, 2024 12:17
Copy link
Member

@denisonbarbosa denisonbarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question, but won't block on it. Thanks for addressing all of this!

internal/grpc/logstreamer/server.go Show resolved Hide resolved
internal/policies/mount/mount.go Outdated Show resolved Hide resolved
didrocks and others added 2 commits August 29, 2024 15:22
Annotate false positive linting due to string const being localized
Fix the logContextKey not being an anonymous struct

Co-authored-by: Jean-Baptiste Lallement <jean-baptiste@ubuntu.com>
@didrocks didrocks force-pushed the dependabot/go_modules/tools/github.com/golangci/golangci-lint-1.60.3 branch from 28b6731 to 2b276ee Compare August 29, 2024 13:22
@didrocks
Copy link
Member

@denisonbarbosa mind double checking I didn’t let one of them? Code Sanity passes

@denisonbarbosa
Copy link
Member

@denisonbarbosa mind double checking I didn’t let one of them? Code Sanity passes

Everything looks great. Well done!

@didrocks didrocks merged commit 738cb3d into main Aug 30, 2024
4 checks passed
@didrocks didrocks deleted the dependabot/go_modules/tools/github.com/golangci/golangci-lint-1.60.3 branch August 30, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants