Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): disable systemd-networkd-wait-online on Noble #969

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

GabrielNagy
Copy link
Contributor

We already did this for Jammy and it appears that Noble exhibits the same issue which causes provisioning to take 2 minutes longer than usual (due to the timing out).

What's surprising to me is that we didn't need to do the same for Lunar or Mantic and I'm afraid I don't have a logical explanation for this, but hey... it works!

Apr 24 12:54:18 adsys-e2e-template-noble-54d0ed77-2d35-49ed-8823-4047188a7b9a systemd[1]: Started systemd-networkd.service - Network Configuration.
Apr 24 12:54:18 adsys-e2e-template-noble-54d0ed77-2d35-49ed-8823-4047188a7b9a systemd-networkd[669]: eth0: Link UP
Apr 24 12:54:18 adsys-e2e-template-noble-54d0ed77-2d35-49ed-8823-4047188a7b9a systemd-networkd[669]: eth0: Gained carrier
Apr 24 12:54:18 adsys-e2e-template-noble-54d0ed77-2d35-49ed-8823-4047188a7b9a systemd[1]: Starting systemd-networkd-wait-online.service - Wait for Network to be Configured...
Apr 24 12:54:18 adsys-e2e-template-noble-54d0ed77-2d35-49ed-8823-4047188a7b9a systemd-networkd[669]: eth0: Gained IPv6LL
Apr 24 12:54:41 adsys-e2e-template-noble-54d0ed77-2d35-49ed-8823-4047188a7b9a systemd[1]: systemd-fsckd.service: Deactivated successfully.
Apr 24 12:54:49 adsys-e2e-template-noble-54d0ed77-2d35-49ed-8823-4047188a7b9a kernel: hv_balloon: Max. dynamic memory size: 4096 MB
Apr 24 12:56:18 adsys-e2e-template-noble-54d0ed77-2d35-49ed-8823-4047188a7b9a systemd-networkd-wait-online[670]: Timeout occurred while waiting for network connectivity.
Apr 24 12:56:18 adsys-e2e-template-noble-54d0ed77-2d35-49ed-8823-4047188a7b9a systemd[1]: systemd-networkd-wait-online.service: Main process exited, code=exited, status=1/FAILURE
Apr 24 12:56:18 adsys-e2e-template-noble-54d0ed77-2d35-49ed-8823-4047188a7b9a systemd[1]: systemd-networkd-wait-online.service: Failed with result 'exit-code'.
Apr 24 12:56:18 adsys-e2e-template-noble-54d0ed77-2d35-49ed-8823-4047188a7b9a systemd[1]: Failed to start systemd-networkd-wait-online.service - Wait for Network to be Configured.

Partly fixes UDENG-2528

We already did this for Jammy and it appears that Noble exhibits the
same issue which causes provisioning to take 2 minutes longer than usual
(due to the timing out).

What's surprising to me is that we didn't need to do the same for Lunar
or Mantic and I'm afraid I don't have a logical explanation for this,
but hey... it works!
@GabrielNagy GabrielNagy requested a review from a team as a code owner April 24, 2024 14:33
Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this is weird that it works on intermediate releases…

Anyway, more bashism!

The failing test is not related, but maybe we should log it?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.77%. Comparing base (af74ad4) to head (8d451da).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #969   +/-   ##
=======================================
  Coverage   90.77%   90.77%           
=======================================
  Files          78       78           
  Lines        6886     6886           
=======================================
  Hits         6251     6251           
  Misses        621      621           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GabrielNagy GabrielNagy merged commit 418a5b7 into main Apr 24, 2024
4 checks passed
@GabrielNagy GabrielNagy deleted the disable-networkd-wait-online-noble branch April 24, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants