ci: exclude Samba vendor and mock files from TiCS scan #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didrocks
reviewed
May 13, 2024
internal/policies/certificate/python/vendor_samba/gp/gp_cert_auto_enroll_ext.py
Outdated
Show resolved
Hide resolved
These are either vendored files or mocks used in tests, they should not impact the TiCS coverage report.
GabrielNagy
force-pushed
the
exclude-samba-files-from-tics
branch
from
4637418
to
99b3255
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #995 +/- ##
=======================================
Coverage 90.78% 90.78%
=======================================
Files 78 78
Lines 6890 6890
=======================================
Hits 6255 6255
Misses 621 621
Partials 14 14 ☔ View full report in Codecov by Sentry. |
GabrielNagy
added a commit
that referenced
this pull request
May 13, 2024
We already updated the vendored files in #995, however these are generated by our weekly Samba auto-patch workflow. The simplest way to ensure these comments aren't lost on the next workflow run is to add a patch responsible for adding them. A manual run of the workflow steps reports no changes to the files in internal/policies/ which is what we want.
GabrielNagy
added a commit
that referenced
this pull request
May 13, 2024
We already updated the vendored files in #995, however these are generated by our weekly Samba auto-patch workflow. The simplest way to ensure these comments aren't lost on the next workflow run is to add a patch responsible for adding them. A manual run of the workflow steps reports no changes to the files in `internal/policies/` which is what we want. Fixes UDENG-2759
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are either vendored files or mocks used in tests, they should not impact the TiCS coverage report.
Part of UDENG-2759 (still need to handle the Samba auto-update workflow)