-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Used @freezed to create Rating class #1669
base: main
Are you sure you want to change the base?
Conversation
Everyone contributing to this PR have now signed the CLA. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
@@ -30,6 +30,8 @@ abstract class $ChartDataCopyWith<$Res> { | |||
_$ChartDataCopyWithImpl<$Res, ChartData>; | |||
@useResult | |||
$Res call({double rawRating, common.Rating rating}); | |||
|
|||
$RatingCopyWith<$Res> get rating; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be an issue with nested freezed
classes here - this is only part of ratings.dart
but not chart.dart
. Chart
is another freezed
class, that has a Rating
field.
I don't know from the top of my head how to fix this, though.
Everyone contributing to this PR have now signed the CLA. Thanks! |
Everyone contributing to this PR have now signed the CLA. Thanks! |
No description provided.