feat: Expose the login code as extra parameter in the QRCode model #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output of skip2/go-qrcode ToSmallString() includes an extra trailing empty line that we don't want to show, so drop it
It's nicer to have it aligned to the qrcode itself
We need to expose the code separately as different field so that the UI can show it properly both in GDM and in PAM client. The field is required
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
==========================================
+ Coverage 84.86% 84.92% +0.06%
==========================================
Files 76 76
Lines 6091 6129 +38
Branches 85 85
==========================================
+ Hits 5169 5205 +36
- Misses 646 648 +2
Partials 276 276 ☔ View full report in Codecov by Sentry. |
|
It adds more that an optional QR code. The impact on the project is deeper than initially discussed. Lets park this for now. |
First commits just add the code support, so I can just drop the last one and move it to another PR to keep it simpler. I added it all here since it looked related enough. |
This allows to keep supporting gdm, until it doesn't get updated since it has not support for the qrcode code yet
3v1n0
changed the title
denisonbarbosa
approved these changes
Jun 20, 2024
denisonbarbosa
changed the title
didrocks
approved these changes
Jun 21, 2024
This was referenced Jun 25, 2024
denisonbarbosa
added a commit
to ubuntu/authd-oidc-brokers
that referenced
this pull request
Jun 26, 2024
After the change introduced in authd by ubuntu/authd#387, we can now provide the device code as a separate field in the layout to improve the way it's rendered by PAM.
denisonbarbosa
added a commit
to ubuntu/authd-oidc-brokers
that referenced
this pull request
Jun 26, 2024
After the change introduced in authd by ubuntu/authd#387, we can now provide the device code as a separate field in the layout to improve the way it's rendered by PAM.
denisonbarbosa
added a commit
to ubuntu/authd-oidc-brokers
that referenced
this pull request
Jun 27, 2024
This contains a couple of adjustments to our AuthenticationModes-related functions: GetAuthenticationModes and SelectAuthenticationMode (very minor). Details are explained in more detail in the commit messages, but the TLDR is: 1- Simplify a bit of the logic in the functions; 2- Add support for the new `code` layout field introduced in [authd#387](ubuntu/authd#387); 3- Use a more comprehensive name for the authentication mode related to the device authentication; 4- Only show device authentication as a valid authentication mode if the provider is reachable and supports this mode; UDENG-3121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the qrcode code as a required argument, while make possible for UI not to support qrcode rendering, but still being able to login via login code.
UDENG-3013