Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GNOME accent colors #908

Closed
3v1n0 opened this issue Aug 3, 2024 · 3 comments · Fixed by #911
Closed

Support GNOME accent colors #908

3v1n0 opened this issue Aug 3, 2024 · 3 comments · Fixed by #911
Assignees

Comments

@3v1n0
Copy link

3v1n0 commented Aug 3, 2024

GNOME 47 will supports accent colors, however this comes with some limitations as the number of colors and their values are limited.

We still have to define a full migration strategy, but ideally we're removing the ubuntu specific colors and use upstream ones.

We may tune some of the upstream colors to match the previous colors of us, but this is not yet defined (for sure we'll do it for the orange though).

So, opening this so that we can prepare a migration strategy (we'll need to listen on xdg-setting for the value in use), while more details need to come.

For sure yaru.dart will need to support the same logic to get the color to use depending on the xdg-setting value.

@Feichtmeier
Copy link
Member

Feichtmeier commented Aug 3, 2024

Thanks for the heads-up!

When we do this we don't need to drop it for lower specific Ubuntu versions though, right?
We can keep the themes, they don't harm. But we need a mechanism to detect which theme suite shall be used I guess
I'm not really the low level guy so I fear the new mechanism needs to be implemented by some of you. I can add the new themes though

Edit: if it's dynamic we can already create new themes on the fly, I can post an example

@Feichtmeier Feichtmeier self-assigned this Aug 14, 2024
@Feichtmeier Feichtmeier changed the title Drop support for ubuntu accent colors and migrate to GNOME accent colors Support GNOME accent colors Aug 14, 2024
Feichtmeier added a commit that referenced this issue Aug 14, 2024
@3v1n0
Copy link
Author

3v1n0 commented Aug 22, 2024

FYI we're still tuning the brown accent a bit, so I can give the final colors we're using soon.

In yaru css theme we compute the colors via some contrast optimization function, but once finalized I can give you the final ones

@Feichtmeier
Copy link
Member

FYI we're still tuning the brown accent a bit, so I can give the final colors we're using soon.

In yaru css theme we compute the colors via some contrast optimization function, but once finalized I can give you the final ones

sure, an update with the new color (detection) is now available for your flutter collegues
we can still change it then, just keep me updated in time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants