Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NavigationPage #474

Merged
merged 4 commits into from
Jan 10, 2023
Merged

Conversation

d-loose
Copy link
Member

@d-loose d-loose commented Jan 9, 2023

2023-01-09.17-27-57.mp4

I'll add some widget tests in a separate PR

Pull request checklist

  • This PR does not introduce visual changes, or
    • I ran flutter test --update-goldens and committed the changes if there were any, or
    • I added before/after/light/dark screenshots if the visual changes I made were not covered by golden tests.
      Before After
      Light
      Dark

@Feichtmeier
Copy link
Member

Thank you @d-loose

Just for the sake of consistency, could use YaruBackButton for the leading widget?

@jpnurmi
Copy link
Member

jpnurmi commented Jan 10, 2023

Sorry, I can't help myself but there's something inconsistent that stands out :D

image

@d-loose
Copy link
Member Author

d-loose commented Jan 10, 2023

Naming things is certainly not one of my strengths 😆
YaruNavigationPage is an actual widget though - this page showcases the navigation in both YaruNavigationPage and YaruMasterDetailPage, depending on the "compact mode" setting. I wouldn't mind calling it YaruNavigationPage though.

@Feichtmeier
Copy link
Member

🤷 yeah just change it xD For a moment I thought you mean NaviGationPage to match the camel case line xD

@jpnurmi
Copy link
Member

jpnurmi commented Jan 10, 2023

Or maybe we could call it YaruBackButton :)

@Feichtmeier
Copy link
Member

The GitHub cloud ☁️ helpers have a bad day. Container for the flutter snap test always hangs. Restarting

@Feichtmeier Feichtmeier merged commit 07b9f85 into ubuntu:main Jan 10, 2023
@jpnurmi jpnurmi mentioned this pull request Jan 11, 2023
@jpnurmi jpnurmi mentioned this pull request Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants