add NavigationPage #474
Merged
add NavigationPage #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @d-loose Just for the sake of consistency, could use YaruBackButton for the leading widget? |
d-loose
force-pushed
the
navigation-page-example
branch
from
ec7d1f5
to
3258dd3
Compare
|
Sorry, I can't help myself but there's something inconsistent that stands out :D
|
|
Naming things is certainly not one of my strengths 😆 |
|
🤷 yeah just change it xD For a moment I thought you mean NaviGationPage to match the camel case line xD |
|
Or maybe we could call it |
|
The GitHub cloud ☁️ helpers have a bad day. Container for the flutter snap test always hangs. Restarting |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2023-01-09.17-27-57.mp4
I'll add some widget tests in a separate PR
Pull request checklist
flutter test --update-goldensand committed the changes if there were any, or