Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose YaruWindow API #562

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Expose YaruWindow API #562

merged 1 commit into from
Jan 25, 2023

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Jan 24, 2023

This allows apps to set the window title, and the relevant window attributes (minimizable, maximizable, closable) in a way that doesn't need the recently added updateState() workaround.

Before:

windowManager.setClosable(false);
YaruWindow.of(context).updateState(); // or YaruWindow.updateState(context);

After:

YaruWindow.of(context).setClosable(false); // or YaruWindow.setClosable(context, false);

@jpnurmi
Expose YaruWindow API
2a0d68e 
This allows apps to set the window title, the relevant window attributes
(minimizable, maximizable, closable) in a way that doesn't need the
recently added updateState() workaround.
@jpnurmi
Copy link
Member Author

jpnurmi commented Jan 25, 2023

@Feichtmeier I promise this is the last one I need for the installer. :)

Feichtmeier
Feichtmeier approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@Feichtmeier Feichtmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jpnurmi jpnurmi merged commit 543050a into ubuntu:main Jan 25, 2023
@jpnurmi jpnurmi deleted the yaru-window branch January 25, 2023 07:52
@jpnurmi jpnurmi mentioned this pull request Jan 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Feichtmeier Feichtmeier Feichtmeier approved these changes

@Jupi007 Jupi007 Awaiting requested review from Jupi007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpnurmi @Feichtmeier