Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add YaruChoiceChipBar #713

Merged
merged 4 commits into from
Jun 21, 2023
Merged

Add YaruChoiceChipBar #713

merged 4 commits into from
Jun 21, 2023

Conversation

Feichtmeier
Copy link
Member

@Feichtmeier Feichtmeier commented Jun 19, 2023 •
edited
Loading

I thought this is a useful wrapping around choicechips. I can use it inside MusicPod for filtering different things :)

Bildschirmaufzeichnung.vom.2023-06-19.21-52-35.webm

Jupi007
Jupi007 reviewed Jun 19, 2023
View reviewed changes
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot test it for now, but it looks great so far!

lib/src/widgets/yaru_choice_chip_bar.dart Outdated Show resolved Hide resolved
Jupi007
Jupi007 reviewed Jun 19, 2023
View reviewed changes
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested it.
Is i possible to disable the corresponding navigation button when you reach the end?

Jupi007
Jupi007 approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Jupi007
Jupi007 approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@Jupi007 Jupi007 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

EDIT: sorry I got an error and I sent the approval twice 😅

@Feichtmeier
Copy link
Member Author

@jpnurmi any veto?

@jpnurmi
Copy link
Member

jpnurmi commented Jun 21, 2023

👍

@Feichtmeier Feichtmeier merged commit e1b3725 into main Jun 21, 2023
@Feichtmeier Feichtmeier deleted the choice_chip_bar branch June 21, 2023 09:41
@github-actions github-actions bot mentioned this pull request Jun 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jupi007 Jupi007 Jupi007 approved these changes

@jpnurmi jpnurmi Awaiting requested review from jpnurmi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Feichtmeier @jpnurmi @Jupi007